use setuptools #25
Merged
use setuptools #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly, the hole package structure is not very well. If you are interested go for setup.cfg.
…On Wed, Jan 27, 2021, at 5:14 AM, Michael Milton wrote:
The current setup.py doesn't actually install its requirements, because
it uses the out of date distutils specification rather than setuptools.
To be honest setup.py is being replaced by setup.cfg anyway, but I
figured I might as well make this small improvement in the meantime
You can view, comment on, or merge this pull request online at:
#25
Commit Summary
* Fix dependency specification
* Use setuptools
File Changes
* *M* .idea/inspectionProfiles/profiles_settings.xml
<https://github.com/hildensia/bayesian_changepoint_detection/pull/25/files#diff-9fb34448452829ed3cd715b49c0f4494fe0b97a4aef2a5b23e12c486ed932273> (3)
* *M* setup.py
<https://github.com/hildensia/bayesian_changepoint_detection/pull/25/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7> (22)
Patch Links:
*
https://github.com/hildensia/bayesian_changepoint_detection/pull/25.patch
*
https://github.com/hildensia/bayesian_changepoint_detection/pull/25.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#25>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVBVDIXE2PIYXWNYPPXADS36HLBANCNFSM4WUSFZPQ>.
|
hildensia
approved these changes
Jan 28, 2021
| version=bayesian_changepoint_detection.__version__, | ||
| description='Some Bayesian changepoint detection algorithms', | ||
| author='Johannes Kulick', | ||
| author_email='johannes.kulick@ipvs.uni-stuttgart.de', |
There was a problem hiding this comment.
Since you are updating it here anyway, can you change this to mail@johanneskulick.net, thanks.
There was a problem hiding this comment.
I am happy to do this, but you've already merged. Or do you mean when I update to setup.cfg?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup.py doesn't actually install its requirements, because it uses the out of date distutils specification rather than setuptools. To be honest setup.py is being replaced by setup.cfg anyway, but I figured I might as well make this small improvement in the meantime